[PATCH] nvme: restore use of blk_path_error() in nvme_complete_rq()

[Chao Leng]

On 2020/8/10 20:43, Christoph Hellwig wrote:
> Just returning from my vacation, and I'm really surprised about
> this discussion.
> 
> If you want to fix a device mapper / block layer interaction you do
> not change nvme code to use suboptimal interfaces.
Agree. Nvme define path error and local retry mechanism. It is more
reasonable to use the new mechanism.
> 
> One of the reasons for the nvme multipath design was to allow for
> tighter integration with protocol features, and making nvme do a detour
> through the block layer for no good reason at all does not help with
> that at all.
Nvme should use local retry mechanism. But now we first check the flag:
REQ_FAILFAST_TRANSPORT, if work with dm-multipath, REQ_FAILFAST_TRANSPORT
will be set, this interrupt local retry.
> 
> And if you want to support the TP that added the new command interrupted
> status code please read through it - the status code itself is just a
> small part of it, and none of the changes proposed in these discussions
> would lead to a proper implementation.
> .
>