[PATCH 08/14] nvmet: use nvme write cmd group setting op_flag

Keith Busch kbusch at kernel.org
Mon Aug 10 19:26:47 EDT 2020


On Mon, Aug 10, 2020 at 11:23:03PM +0000, Chaitanya Kulkarni wrote:
> On 8/10/20 16:10, Keith Busch wrote:
> >> Good point, maybe they are needed for backward compatibility ?
> >> Can we be consistent with the backends and different flags ?
> > I don't really follow what compatibility this could be about, but if
> > they're not used for REQ_OP_DRV_IN/OUT commands, as it appears to me to
> > be the case, you should just remove them rather than add more.
> > 
> 
> Then we have to remove in bdev backend also ?

No. That target doesn't use REQ_OP_DRV_IN/OUT request ops through
blk_execute_rq(). That target uses REQ_OP_READ/WRITE bio ops through
submit_bio(). Big difference.



More information about the Linux-nvme mailing list