[PATCH 03/14] nvmet: use consistent type with id->nlbaf

Chaitanya Kulkarni Chaitanya.Kulkarni at wdc.com
Mon Aug 10 19:20:44 EDT 2020


On 8/10/20 15:57, Logan Gunthorpe wrote:
>> It is a type miss-match, why we need fast type ? its not in fast path.
> It's just normal to use an int for a loop variable instead of something
> specific like a u8. The type mismatch isn't really an issue here...
> 
> Logan
> 
> 
> 

Just because it is norm that doesn't mean we should have type missmatch.

Also, what is it we are getting out of having type missmatch?

This may lead to some remote static analyzer generating type missmatch
warnings when someone tries to run proprietary code analysis tools.
This patch pro-actively avoids that.



More information about the Linux-nvme mailing list