[PATCH 08/14] nvmet: use nvme write cmd group setting op_flag

Keith Busch kbusch at kernel.org
Mon Aug 10 19:10:53 EDT 2020


On Mon, Aug 10, 2020 at 11:04:36PM +0000, Chaitanya Kulkarni wrote:
> On 8/10/20 14:11, Keith Busch wrote:
> > Are these flags even used? I'm not finding these getting copied to the
> > 'struct request' in this command's setup, nor am I finding anything in
> > the blk_execute_rq() path that checks the bio's bi_opf.
> > 
> 
> Good point, maybe they are needed for backward compatibility ?
> Can we be consistent with the backends and different flags ?

I don't really follow what compatibility this could be about, but if
they're not used for REQ_OP_DRV_IN/OUT commands, as it appears to me to
be the case, you should just remove them rather than add more.



More information about the Linux-nvme mailing list