[PATCH 08/14] nvmet: use nvme write cmd group setting op_flag

Chaitanya Kulkarni Chaitanya.Kulkarni at wdc.com
Mon Aug 10 19:08:06 EDT 2020


>> +static inline bool nvmet_write_cmd_group(__u8 opcode)
>> +{
>> +	bool ret;
>> +
>> +	/* NVM Express Revision 1.4 Figure 462. */
>> +	switch (opcode) {
>> +	case nvme_admin_format_nvm:
>> +	case nvme_admin_ns_attach:
>> +	case nvme_admin_ns_mgmt:
>> +	case nvme_admin_sanitize_nvm:
>> +	case nvme_admin_security_send:
> 
> All of these admin commands are rejected as INVALID_OPCODE in
> nvmet_parse_passthru_admin_cmd(). So adding them here seems confusing at
> best.
> 

These are extremely important commands, why these commands are
rejected ?

What is the use of passthru if host cannot create namespaces format ns 
and sanitize the important data ?

Implementing Namespace management commands are in non-passthru mode are
NACKed if I remember correctly.

Irrespective of that it better have it documented there is no harm.
> Logan
> 




More information about the Linux-nvme mailing list