[PATCH 04/14] nvmet: use consistent type for op_flag
Logan Gunthorpe
logang at deltatee.com
Mon Aug 10 17:56:59 EDT 2020
On 2020-08-10 12:54 p.m., Chaitanya Kulkarni wrote:
> In function nvmet_passthru_map_sg() we set the bio->bi_opf ored with
> req_op and op_flags set based on the NVMe cmd. The variable bio->bi_opf
> is declared as unsigned int use same type for op_flag.
>
> Also, adjust the indentation according to new length.
I think you mean "order" (per reverse christmas-tree convention)... Not
"indentation".
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
Reviewed By: Logan Gunthorpe <logang at deltatee.com>
> ---
> drivers/nvme/target/passthru.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/passthru.c b/drivers/nvme/target/passthru.c
> index 13d73f36e927..58377420874f 100644
> --- a/drivers/nvme/target/passthru.c
> +++ b/drivers/nvme/target/passthru.c
> @@ -180,9 +180,9 @@ static void nvmet_passthru_req_done(struct request *rq,
>
> static int nvmet_passthru_map_sg(struct nvmet_req *req, struct request *rq)
> {
> + unsigned int op_flags = 0;
> int sg_cnt = req->sg_cnt;
> struct scatterlist *sg;
> - int op_flags = 0;
> struct bio *bio;
> int i, ret;
>
>
More information about the Linux-nvme
mailing list