[PATCH 01/14] nvmet: for pt I/O cmds annotate req->sg_cnt likely

Logan Gunthorpe logang at deltatee.com
Mon Aug 10 17:54:04 EDT 2020


Hey,

You forgot to CC me again....

On 2020-08-10 12:54 p.m., Chaitanya Kulkarni wrote:
> I/O Commands (nvme_cmd_read, nvme_cmd_write) are most command commands
> when accessing passthru controller. For I/O commands data is represented
> in SG list, so sg_cnt != 0 in most cases.
> 
> Annotate req->sg_cnt check with likely.

Does adding these likely annotations actually produce any benefit? Why
can't we rely on the branch predictor in these instances?

I vaguely remember somebody complaining about all the extra likelys and
unlikelys which is why I removed them.

Logan



More information about the Linux-nvme mailing list