[PATCH 00/14] nvmet: passthru few fixes and improvements

Chaitanya Kulkarni chaitanya.kulkarni at wdc.com
Mon Aug 10 14:54:42 EDT 2020


Hi,

Over the weekend while testing I found few fixes and improvements over
passthru. Following is the patch distribution:-

* PATCH 1-7 Adds annotations, fixes type mismatch, trim downs the code &
            uses nvmet_passthru_req_done() instead of duplicating the 
            function. No functionality change.

* Patch 8-9 Updates the flags setting for write commands in fast path.

* PATCH 10-11 Fixes the module ref count Oops in load-unload sequence. 

* PATCH 12-13 Trims down the bio req append n the context of passthru in
              fast path. No functionality change, perf numbers does show
              improvement.

* PATCH 14 Avoids an allocation and uses an inline-bvec-bio combination
           for fast-path when possible.      

I can see nvme-5.9 and nvme-5.9-rc branch, I've generated this series on
nvme-5.9 + http://lists.infradead.org/pipermail/linux-nvme/2020-August/018708.html.

Regards,
Chaitanya

Chaitanya Kulkarni (14):
  nvmet: for pt I/O cmds annotate req->sg_cnt likely
  nvmet: for pt I/O commands use likely for ns check
  nvmet: use consistent type with id->nlbaf
  nvmet: use consistent type for op_flag
  nvmet: get rid of the extra variable
  nvmet: use unlikely for uncommon commands
  nvmet: reuse pt-req-done for rq completion
  nvmet: use nvme write cmd group setting op_flag
  nvmet: based on passthru req control use REQ_FUA
  nvmet: prep patch for pt ctrl put wrapper
  nvmet: fix nvme module ref count Oops
  block: move blk_rq_bio_prep() to linux/blk-mq.h
  nvmet: use minimized version of blk_rq_append_bio
  nvmet: use inline bio for passthru fast path

 block/blk.h                    |  12 ----
 drivers/nvme/host/core.c       |   5 ++
 drivers/nvme/target/nvmet.h    |   1 +
 drivers/nvme/target/passthru.c | 109 +++++++++++++++++++++++----------
 include/linux/blk-mq.h         |  12 ++++
 5 files changed, 93 insertions(+), 46 deletions(-)

-- 
2.22.1




More information about the Linux-nvme mailing list