[RESEND PATCH V2 0/3] nvmet: passthru fixes

Chaitanya Kulkarni chaitanya.kulkarni at wdc.com
Mon Aug 10 14:02:15 EDT 2020


Hi,

This is a small patch-series that fixes a bug in the passthru
submission path and makes the direct call to blk_mq_free_request().

First patch is prep patch to have labels for each action in the
nvnet_execute_passthru_cmd(), second patch fixes the actual oops, third
patch call blk_mq_free_request() directly.

When I pulled I did not found these patches in the repo.

I've regerated this series against branch nvme-5.9
commit b6cec06d19d9 ("nvme-loop: remove extra variable in create ctrl")
and applied it again to make sure git am is successful, please let me
know if you still find patch corruption issues.

Regards,
Chaitanya

* Changes from V1:-
-------------------

1. Don't use fail_XXX and be consistent with out_XXX_action as
   most of the target code labels.
2. Add a out_put_ns label as a prep patch to have proper error
   path handling for each action in passthru cmd setup.
3. Add a out_put_req label for blk_put_request() call and move this
   call to first in the error handling code path. Along with the
   reported but this also fixes potential Oops if nvme_find_get_ns()
   fails in the original code.
4. Add reviewers tag for the blk_mq_free_request() patch.

Chaitanya Kulkarni (3):
  nvmet: add ns tear down label for pt-cmd handling
  nvmet: fix oops in pt cmd execution
  nvmet: call blk_mq_free_request() directly

 drivers/nvme/target/passthru.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

-- 
2.22.1




More information about the Linux-nvme mailing list