[PATCH v2 2/7] nvme: consolidate some nvme-cli utility functions

Chaitanya Kulkarni Chaitanya.Kulkarni at wdc.com
Fri Aug 7 21:47:54 EDT 2020


On 8/7/20 10:15, Sagi Grimberg wrote:
>> I'm okay with having a wrapper for disconnect but for connect and
>> discover command it can have many arguments having a call in the
>> test-case might loose the readability.
> That's why these has default values.
Okay.
> 
>> The downside is it will need argument count handling in the future
>> and makes things not easier when user want to skip certain
>> parameters, closest example would be _create_nvmet_ns().
>>
>> Also if we are adding wrappers why not move $FULL 2>&1 to avoid
>> duplication ?
> Not exactly sure what you meant
> 
Leave it for now.




More information about the Linux-nvme mailing list