[PATCH v2 4/7] tests/nvme: restrict tests to specific transports

Sagi Grimberg sagi at grimberg.me
Fri Aug 7 13:21:01 EDT 2020


>> +_require_nvme_trtype_is_loop() {
>> +	if [[ "${nvme_trtype}" != "loop" ]]; then
>> +		SKIP_REASON="nvme_trtype=${nvme_trtype} is not supported in this test"
>> +		return 1
>> +	fi
>> +	return 0
>> +}
>> +
>> +_require_nvme_trtype_not_pci() {
>> +	if [[ "${nvme_trtype}" == "pci" ]]; then
>> +		SKIP_REASON="nvme_trtype=${nvme_trtype} is not supported in this test"
>> +		return 1
>> +	fi
>> +	return 0
>> +}
>> +
> how about instead of not_pci  if we can requires_nvme_trtype_fabrics ->
> returns true for loop/rdma/tcp etc ?
> 
> It is a same thing, just my preference to void not.

Fine with that.



More information about the Linux-nvme mailing list