[PATCH v2 1/7] nvme: consolidate nvme requirements based on transport type

Sagi Grimberg sagi at grimberg.me
Fri Aug 7 13:14:03 EDT 2020


>> diff --git a/tests/nvme/rc b/tests/nvme/rc
>> index 6ffa971b4308..320aa4b2b475 100644
>> --- a/tests/nvme/rc
>> +++ b/tests/nvme/rc
>> @@ -6,6 +6,25 @@
>>    
>>    . common/rc
>>    
>> +nvme_trtype=${nvme_trtype:-"loop"}
>> +
>> +_nvme_requires() {
>> +	_have_program nvme
>> +	case ${nvme_trtype} in
>> +	loop)
>> +		_have_modules nvmet nvme-core nvme-loop
>> +		_have_configfs
> We should just move nvmet nvme-core configfs _have_nvme_fabrics_common
> which are common for all the transports to avoid the duplication.

That's a minor duplication, not sure it warrants consolidation...



More information about the Linux-nvme mailing list