[PATCH 1/2] nvme: multipath: round-robin: fix single non-optimized path case

George, Martin Martin.George at netapp.com
Fri Aug 7 03:36:35 EDT 2020


On Thu, 2020-08-06 at 21:40 +0200, Martin Wilck wrote:
> On Thu, 2020-08-06 at 15:19 +0200, mwilck at suse.com wrote:
> > From: Martin Wilck <mwilck at suse.com>
> > 
> > If there's only one usable, non-optimized path,
> > nvme_round_robin_path()
> > returns NULL, which is wrong. Fix it by falling back to "old", like
> > in
> > the single optimized path case. Also, if the active path isn't
> > changed,
> > there's no need to re-assign the pointer.
> > 
> > Fixes: 3f6e3246db0e ("nvme-multipath: fix logic for non-optimized
> > paths")
> > Signed-off-by: Martin Wilck <mwilck at suse.com>
> > Reported-by: Martin George <marting at netapp.com>
> 
> I made a mistake here. It should be
> 
> Signed-off-by: Martin George <marting at netapp.com>
> 
> because Martin G. provided the initial idea for the fix.
> 

Thanks MartinW. 

I've also tested this patch and verified that it works fine for all
scenarios including the single ANA non-optimized path scenario. So in
addition to MartinW's Signed-off-by tag, please add

Signed-off-by: Martin George <marting at netapp.com>
Tested-by: Martin George <marting at netapp.com>

as well for this patch. Thank you.

-Martin George


More information about the Linux-nvme mailing list