[PATCH 1/2] nvmet: fix oops in nvmet_execute_passthru_cmd()
Sagi Grimberg
sagi at grimberg.me
Thu Aug 6 15:41:01 EDT 2020
>> I don't think this is quite accurate either. It looks to me like it's
>> just a bug in the error path logic. If the namespace is invalid, it
>> doesn't even try to allocate the request so it should really just order
>> the cleanup correctly and skip it, if it's not allocated.
>>
>> I think a fix like this would be cleaner:
>>
>
> Christoph, Sagi how guys would like to have this fix?
>
> I personally like to avoid introducing new labels unless they are
> extremely necessary.
I think that having an explicit and reverse-ordered target error labels
are always better.
More information about the Linux-nvme
mailing list