[PATCH 1/3] nvme: remove ->cq_vector == -1 check in nvme_queue_rq()

Jens Axboe axboe at kernel.dk
Thu May 17 08:52:48 PDT 2018


On 5/17/18 9:52 AM, Keith Busch wrote:
> On Thu, May 17, 2018 at 09:42:58AM -0600, Jens Axboe wrote:
>> How about this:
>>
>> http://git.kernel.dk/cgit/linux-block/commit/?h=nvme-4.18&id=9913686cb779a046924441cdcac275aa24147122
> 
> Not only better, this also fixes a memory leak: we never called the
> dma_unmap_sg() on this error out case! Let's consider this patch
> separately.

Heh, didn't even notice that.

Christoph, let me know if you want me to post the whole series for your
reshuffling. It's what's on:

http://git.kernel.dk/cgit/linux-block/log/?h=nvme-4.18

now.

-- 
Jens Axboe




More information about the Linux-nvme mailing list