[PATCH v3] nvme: add quirk to force medium priority for SQ creation

Jens Axboe axboe at kernel.dk
Fri May 11 14:05:22 PDT 2018


On 5/11/18 11:02 AM, Keith Busch wrote:
> On Tue, May 08, 2018 at 10:35:39AM -0600, Keith Busch wrote:
>> On Tue, May 08, 2018 at 10:25:15AM -0600, Jens Axboe wrote:
>>> Some P3100 drives have a bug where they think WRRU (weighted round
>>> robin) is always enabled, even though the host doesn't set it. Since
>>> they think it's enabled, they also look at the submission queue
>>> creation priority. We used to set that to MEDIUM by default,
>>> but that was removed in commit 81c1cd98351b. This causes various
>>> issues on that drive. Add a quick to still set MEDIUM priority
>>> for that controller.
>>>
>>> Fixes: 81c1cd98351b ("nvme/pci: Don't set reserved SQ create flags")
>>> Cc: stable at vger.kernel.org
>>> Signed-off-by: Jens Axboe <axboe at kernel.dk>
>>
>> Thanks, applied to nvme-4.18.
> 
> Actually, any concern if I apply for the next 4.17-rc instead? I know
> this breakage isn't all that recent, but there seems to be heightened
> visibility on getting this work-around to users.

Fine with me, it's trivial and the sooner the better...

-- 
Jens Axboe




More information about the Linux-nvme mailing list