[PATCH v2] nvme: add quirk to force medium priority for SQ creation

Jens Axboe axboe at kernel.dk
Tue May 8 09:24:33 PDT 2018


On 5/8/18 10:22 AM, Keith Busch wrote:
> On Tue, May 08, 2018 at 09:54:20AM -0600, Jens Axboe wrote:
>> --- a/drivers/nvme/host/pci.c
>> +++ b/drivers/nvme/host/pci.c
>> @@ -1097,6 +1097,14 @@ static int adapter_alloc_sq(struct nvme_dev *dev, u16 qid,
>>  	int flags = NVME_QUEUE_PHYS_CONTIG;
>>  
>>  	/*
>> +	 * Some drives have a bug that auto-enables WRRU if MEDIUM isn't
>> +	 * set. Since URGENT priority is zeroes, it makes all queues
>> +	 * URGENT.
>> +	 */
>> +	if (ctrl->quirks & NVME_QUIRK_MEDIUM_PRIO_SQ)
>> +		flags |= NVME_SQ_PRIO_MEDIUM;
> 
> 'ctrl' is undeclared in this function; must be 'dev->ctrl.quirks'.

Gah, that's a lot of typos in a simple patch... Sending out v3.

-- 
Jens Axboe




More information about the Linux-nvme mailing list