[PATCH 6/7] nvme_fc: fix nulling of queue data on reconnect

[James Smart]

On 5/7/2018 11:05 PM, Hannes Reinecke wrote:
> On Mon,  7 May 2018 17:12:13 -0700
> "James Smart" <jsmart2021 at gmail.com> wrote:
>
>> @@ -1879,6 +1879,7 @@ nvme_fc_free_queue(struct nvme_fc_queue *queue)
>>   	 */
>>   
>>   	queue->connection_id = 0;
>> +	atomic_set(&queue->csn, 1);
>>   }
>>   
> Huh? What is that doing here?
> Doesn't seem to be related to the remaining patchset.
> Or am I missing something here?

The init_queue calls would normally "init" the structure and set the csn 
back to 1, but it also cleared too much other state as well. Thus they 
were removed. The "free" routine remains, so this CSN setting is a 
"reinit'ing" of the structure - just like zeroing the connection id.

-- james