[PATCH 2/5] nvme: Add ANA base definitions

[Hannes Reinecke]

On 05/04/2018 07:03 PM,  Meneghini, John  wrote:
> Agreed:
> 
> 95:92 - ANAGRPID
> 103:96 - Reserved
> 
> Note that this was changed at the last minute.  There are some older drafts of the NVM_TP_4004 out there.  You want to be sure to use the ratified version from:
> 
> http://nvmexpress.org/resources/specifications/
> 
> NVM Express 1.3 Ratified TPs
> 
> /John
> 
> On 5/4/18, 12:16 PM, "Keith Busch" <keith.busch at linux.intel.com> wrote:
> 
>      On Fri, May 04, 2018 at 01:28:42PM +0200, Hannes Reinecke wrote:
>      > @@ -312,7 +317,8 @@ struct nvme_id_ns {
>      >  	__le16			nabspf;
>      >  	__le16			noiob;
>      >  	__u8			nvmcap[16];
>      > -	__u8			rsvd64[40];
>      > +	__u8			rsvd64[36];
>      > +	__le32			anagrpid;
>      >  	__u8			nguid[16];
>      >  	__u8			eui64[8];
>      >  	struct nvme_lbaf	lbaf[16];
>      
>      Is this the right place for the new field? Your patch has the group ID
>      at byte 100. TP4004 has the ANA Group Identifier starting at byte 92,
>      followed by 8 reserved bytes, then the NGUID.
>      
> 
Ah. Hence. Must've looked at an older copy then.

Will be fixing it up.

Cheers,

Hannes