[PATCH] nvme-cli: fix get_nsid() return value check

[Keith Busch]

On Thu, May 03, 2018 at 06:04:45AM -0400, Chaitanya Kulkarni wrote:
> All the callers of the get_nsid() defined cfg.namespace_id as __u32.
> The true return value of the call:-
> 
> cfg.namespace_id = get_nsid()
> 
> will not be used in case nvme_get_nsid() returns < 0 and
> comparion of
> 
> if (cfg.namespace_id <= 0)
> 
> and will result is cfg.namespace_id > 0 due to type mismatch.
> 
> We fix this scenario by returning the 0 (invalid nsid on get_nsid()
> for nvme_get_nsid() failure case) and adding
> 
> cfg.namespace_id == 0
> 
> for error checking in all the callers of the get_nsid().

Indeed, thanks for the fix. Applied.