[PATCH] nvme/pci: Use async_schedule for initial reset work

Keith Busch keith.busch at linux.intel.com
Wed May 2 08:29:53 PDT 2018


On Tue, May 01, 2018 at 07:33:10PM -0400, Mikulas Patocka wrote:
> On Mon, 30 Apr 2018, Keith Busch wrote:
> 
> > On Sat, Apr 28, 2018 at 05:11:18PM +0800, Ming Lei wrote:
> > > Looks fine,
> > > 
> > > Reviewed-by: Ming Lei <ming.lei at redhat.com>
> > 
> > Thanks, Ming.
> > 
> > Mikulas, would you be able to test this and confirm it works for you?
> > This appears successful in my testing, but want to hear from the source
> > if possible.
> > 
> > Thanks,
> > Keith
> 
> The patch is not correct - scan_work is still called from a workqueue and 
> if it's too slow, the nvme device is not found when mounting root.
> 
> You can add msleep(10000) at the beginning of nvme_scan_work to test for 
> the race condition on your system.
> 
> Here I submit the corrected patch - I added 
> flush_work(&dev->ctrl.scan_work) to nvme_async_probe

Roger that. Will incorporate your adjustment and add your
Tested-by. Thanks for the confirmation.



More information about the Linux-nvme mailing list