[PATCH v3] nvme: expand nvmf_check_if_ready checks

Mike Snitzer snitzer at redhat.com
Thu Mar 29 17:23:38 PDT 2018


On Thu, Mar 29 2018 at  6:13pm -0400,
James Smart <jsmart2021 at gmail.com> wrote:

> Thanks... I'm not sure that this invalidates the patch, as the real
> reason for the patch is to stop the EIO cases without multipath
> where they should have been requeued - the opposite of what you
> want.  I'll take a further look.

I really wasn't making any statement about the patch.  Given you cc'd me
on this patch I thought it was the FAILFAST stuff we talked about last
week.  So I was pointing out I'm not seeing any failfast improvement.
But I'm not confident my mptest test is completely valid... so I was
fishing for your (or others') help.

But looking closer the header does speak to honoring failfast if
present.  dm-multipath does set failfast, so why wouldn't that be
applicable?

Maybe you're saying the patch is more concerned with other details but
did make some attempt to honor failfast..

Mike



More information about the Linux-nvme mailing list