[PATCH v2] nvme: expand nvmf_check_if_ready checks

Christoph Hellwig hch at infradead.org
Wed Mar 28 01:31:36 PDT 2018


> +static inline blk_status_t nvmf_check_if_ready(struct nvme_ctrl *ctrl,
> +		struct request *rq, bool qlive, bool connectivity)

Please rename qlive to queue_live and explain what connectivity means.
Maye this should be is_connected?  How do we get a command on a not
conected queue?

Also I think the function is large enough now to move out of line.



More information about the Linux-nvme mailing list