[PATCH] nvmet: Change error code of discard command if not supported

Christoph Hellwig hch at lst.de
Mon Jan 29 23:05:19 PST 2018


On Mon, Jan 29, 2018 at 08:30:45PM +0200, Sagi Grimberg wrote:
> Actually I don't think we are allowed to fail with this status. We claim
> we support dsm regardless of the underlying backend device (because we
> can expose different devices in the same subsystem), so we can't fail
> a valid dsm command on invalid opcode. Either we keep the existing
> behavior or we simply return success as dsm is a hint anyways...

Yes, we should return success here.



More information about the Linux-nvme mailing list