[RFD] passthrough ioctl interface considered harmful?

Keith Busch keith.busch at intel.com
Wed Jan 24 07:59:35 PST 2018


On Wed, Jan 24, 2018 at 04:01:01PM +0100, Johannes Thumshirn wrote:
> Inspired by the discussion at [1] I've distilled a small test-case [1] which
> deletes QID 1 submission and completions queues. When running this while I/O
> is in-flight we obviously get timeouts and thus force controller resets.
> 
> For some commands commands (nvme_admin_format_nvm, nvme_admin_sanitize_nvm) we
> do already check whether it is a good idea or not and at least warn the user
> about the possible side effects.
> 
> Question here is, should we extend the list and/or block specific commands (at
> least while I/O is running)?

I like to think if you misuse the interface, you get to keep both
pieces. With great power comes great responsibility.



More information about the Linux-nvme mailing list