[PATCH 2/5] nvme: Ending failed unstarted requests

Sagi Grimberg sagi at grimberg.me
Tue Jan 23 05:02:27 PST 2018


>> +static void nvme_end_unstarted_request(struct request *req, void *data,
>> +				       bool reserved)
>> +{
>> +	if (blk_mq_request_started(req))
>> +		return;
>> +
>> +	dev_dbg_ratelimited(((struct nvme_ctrl *) data)->device,
>> +				"Ending I/O %d", req->tag);
>> +	blk_mq_end_request(req, BLK_STS_IOERR);
>> +}
>> +
> 
> This unstarted requests have not been dequeued from the blk-mq queue.
> We cannot end them directly.

I think we cannot complete them. I think its fine to end them.



More information about the Linux-nvme mailing list