[PATCH 1/4] IB/core: add support for draining Shared receive queues

Bart Van Assche Bart.VanAssche at wdc.com
Thu Jan 18 10:06:09 PST 2018


On Wed, 2018-01-17 at 09:35 -0600, Steve Wise wrote:
> > +	if (wait_for_completion_timeout(&qp->srq_completion, 10 * HZ) > 0)
> > +		ib_process_cq_direct(cq, -1);
> > +}
> 
> Perhaps a WARN_ONCE is warranted? 

Agreed. I would also like to see a WARN_ONCE() if the timeout expires before
the completion has been signaled.

Bart.


More information about the Linux-nvme mailing list