[PATCH 1/2] nvme: pci: replace magic number with readable size macro in hmb code

Minwoo Im minwoo.im.dev at gmail.com
Wed Jan 17 05:00:10 PST 2018


On Mon, Jan 15, 2018 at 5:44 PM, Christoph Hellwig <hch at lst.de> wrote:
> SZ_4K does not add any value at all.  The SZ constants may make some
> size in the megabyte and larger ranges where the multiples of 1024
> aren't totally obviously, but they certainly don't for 4 digit values.

Christoph,

Thanks for giving your kind review.
Do you mean that SZ_* constants should _not_ be used to represent
small size like 4K?



More information about the Linux-nvme mailing list