[PATCH 1/2] nvme: pci: replace magic number with readable size macro in hmb code

[Minwoo Im]

On Mon, Jan 15, 2018 at 11:08 AM, Keith Busch <keith.busch at intel.com> wrote:
> On Sun, Jan 14, 2018 at 08:40:40PM +0900, Minwoo Im wrote:
>> Those three identify fields(hmpre, hmmin, hmminds) have size in 4KB
>> units.
>>
>> Replace magic numbers with human-readable size macro.
>>
>> Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
>
> Looks fine, though I thought an explicit #include <linux/sizes.h> is
> in order since it's not obvious how we're pulling in these defines, but
> there's already other SZ_* macro uses in this file, so it must be safe!
>
> Reviewed-by: Keith Busch <keith.busch at intel.com>

Keith,

Thanks for your kind review.
I agree that explicit #include always seems right.