[PATCH 1/2] nvme-fabrics: Fix memory leak when parsing host ID option

[Johannes Thumshirn]

On Fri, Jan 12, 2018 at 12:00:32PM -0800, Roland Dreier wrote:
> On Fri, Jan 12, 2018 at 2:16 AM, Johannes Thumshirn <jthumshirn at suse.de> wrote:
> > Looks good,
> > Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
> >
> > Do you mind fixing the same pattern on:
> > - NVMF_OPT_TRANSPORT
> > - NVMF_OPT_NQN
> > - NVMF_OPT_TRADDR
> > - NVMF_OPT_TRSVCID
> > - NVMF_OPT_HOST_TRADDR
> > as well?
> 
> Thanks for the review.  I don't think the same pattern is there for
> the other options - a pointer to the string is
> stored in opts and freed in nvmf_free_options(). NVMF_OPT_HOST_ID is
> unique in that we don't stash the
> strdup'ed pointer anywhere.

Correct. I'm sorry for the false alarm.

-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850