[PATCH 1/2] nvme-fabrics: Fix memory leak when parsing host ID option
Roland Dreier
roland at kernel.org
Fri Jan 12 12:00:32 PST 2018
On Fri, Jan 12, 2018 at 2:16 AM, Johannes Thumshirn <jthumshirn at suse.de> wrote:
> Looks good,
> Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
>
> Do you mind fixing the same pattern on:
> - NVMF_OPT_TRANSPORT
> - NVMF_OPT_NQN
> - NVMF_OPT_TRADDR
> - NVMF_OPT_TRSVCID
> - NVMF_OPT_HOST_TRADDR
> as well?
Thanks for the review. I don't think the same pattern is there for
the other options - a pointer to the string is
stored in opts and freed in nvmf_free_options(). NVMF_OPT_HOST_ID is
unique in that we don't stash the
strdup'ed pointer anywhere.
- R.
More information about the Linux-nvme
mailing list