[PATCH] nvme-pci: calculate iod and avg_seg_size just before use them

jianchao.wang jianchao.w.wang at oracle.com
Thu Jan 11 17:31:21 PST 2018


Hi Keith

Thanks for your kindly response.

On 01/11/2018 11:48 PM, Keith Busch wrote:
> On Thu, Jan 11, 2018 at 01:09:39PM +0800, Jianchao Wang wrote:
>> The calculation of iod and avg_seg_size maybe meaningless if
>> nvme_pci_use_sgls returns before uses them. So calculate
>> just before use them.
> 
> The compiler will do the right thing here, but I see what you mean. I
> think Christoph has some SGL improvements coming, though, that will
> obviate this.
> 
Yeah, that's great.

Thanks
Jianchao



More information about the Linux-nvme mailing list