[PATCH 1/1] nvme: Modify the debug level for setting shutdown timeout
Max Gurtovoy
maxg at mellanox.com
Thu Jan 4 09:48:04 PST 2018
Hi Martin,
On 1/4/2018 7:24 PM, Martin K. Petersen wrote:
>
> Max,
>
>> but shutdown_timeout is a module param that one can set to be 10 secs
>> (for example) and then it might be == transition_time and we won't see
>> the print. Then is it not a buggy device anymore ? :)
>
> The intent was to only print when the resulting shutdown_timeout
> deviated from the default value (whether the driver default or the
> admin-provided module parameter).
>
> My only concern with info over warning is that info is often dropped.
> And therefore you have a harder time finding out which value was in
> effect when you subsequently peak at the logs.
>
Ok, it just bothered me to see this print every time I probed the device.
But I can live with that. You can ignore this patch.
-Max.
More information about the Linux-nvme
mailing list