[PATCH] nvme: Use __func__ macro in place of function name

John Pittman jpittman at redhat.com
Fri Feb 16 05:28:19 PST 2018


Sure Johannes.  Sounds good to me!

On Fri, Feb 16, 2018 at 2:35 AM, Johannes Thumshirn <jthumshirn at suse.de> wrote:
> On Thu, Feb 15, 2018 at 03:42:58PM -0500, John Pittman wrote:
>>               dev_err(ctrl->device,
>> -                     "failed nvme_keep_alive_end_io error=%d\n",
>> -                             status);
>> +                     "failed %s error=%d\n", __func__, status);
>
> how about:
>                 dev_err(ctrl->device, "failed to send nvme keepalive %d\n",
>                         status);
>
> as the function name isn't really needed for the error description at all and
> barely transports any information to the user.
>
> Byte,
>         Johannes
>
> --
> Johannes Thumshirn                                          Storage
> jthumshirn at suse.de                                +49 911 74053 689
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850



More information about the Linux-nvme mailing list