[PATCH 2/2] nvme: Don't use a stack buffer for keep-alive command

Keith Busch keith.busch at intel.com
Mon Feb 12 12:07:18 PST 2018


On Mon, Feb 12, 2018 at 09:39:52PM +0200, Sagi Grimberg wrote:
> > > I'm fine with fixing this locally, btw isn't this exact same stale sqe
> > > happen in pci's nvme_delete_queue?
> > 
> > Yeah, this is the other case. Fortunately that never gets called on a
> > quiesced admin queue, so we should be 'ok', but moving the command from
> > the stack into struct nvme_queue would be the right thing to do.
> 
> So are you fine with picking Roland's patch to 4.16-rc?

I am okay with it. If we need to change this interface in the long term,
this is looks like an okay stop-gap until then.
 
> Christoph?



More information about the Linux-nvme mailing list