[PATCH] NVMe-CLI Fix command failures in regress script

[Jeffrey Lien]

Ok, that makes sense.  I should have thought to try that; sorry for the trouble.   

I did find 2 other problems/failures when using the block device though:
1)  The flush command has a default namespace id of All ID's (0xffffffff) which causes it to fail.  So to fix that either:
    * The default ns id has to change for the flush command or 
    * The "-n 1" parm needs to be added to the flush command in the regress script 
2) The --block-count=0 setting in the read/write commands fails when the nvme drive is formatted with a lba data size of 512 bytes.  Setting it to 8 seems to work for both  512 and 4k bytes lba data size.  
    
I can recreate the patch with these fixes, just not sure which option to take with the flush command. 

Jeff Lien

-----Original Message-----
From: Keith Busch [mailto:keith.busch at intel.com] 
Sent: Monday, February 5, 2018 10:57 AM
To: Jeffrey Lien
Cc: linux-nvme at lists.infradead.org; David Darrington
Subject: Re: [PATCH] NVMe-CLI Fix command failures in regress script

On Mon, Feb 05, 2018 at 04:49:11PM +0000, Jeffrey Lien wrote:
> Keith,
> That doesn't seem to happen with our nvme device.  Below is what I get when I run the regress script as is.  Am I missing something on the invocation?
> 
> ./regress -d /dev/nvme0 -l -w
                    ^^^^^

That's a character device. You need to use a block device, like /dev/nvme0n1.