[PATCH] nvme-cli: Add ioctl retry support for connect-all

James Smart james.smart at broadcom.com
Mon Apr 30 09:45:36 PDT 2018


OK. I still believe we'll keep adding it in, but I'm good with a reduced 
patch.

-- james


On 4/27/2018 2:39 PM, Keith Busch wrote:
> On Fri, Apr 27, 2018 at 10:29:01AM -0700, James Smart wrote:
>>   /* Generic passthrough */
>> -int nvme_submit_passthru(int fd, int ioctl_cmd, struct nvme_passthru_cmd *cmd);
>> +int nvme_submit_passthru(int fd, int ioctl_cmd, struct nvme_passthru_cmd *cmd,
>> +		int maxretry);
> Hi James,
>
> Since the far majority of the callers don't care for retries, let's
> leave this API alone and create a new one that takes the retries. The
> old API can call the new one with the default value of NO_RETRIES, and
> that should simplify this patch significantly.
>
> Thanks,
> Keith




More information about the Linux-nvme mailing list