[PATCH 1/2 V2] nvme-rdma: Fix race between queue timeout and error recovery

Sagi Grimberg sagi at grimberg.me
Sun Apr 8 08:26:31 PDT 2018


> When returning BLK_EH_HANDLED from nvme_rdma_timeout() the block layer
> complete the request.
> Error recovery may also complete the request when aborting the requests.
> 

This is still not a sufficient change log.

You need to describe why is this being done vs. invalidating the rkey
in the timeout handler. And what does "may also" mean?

Second, isn't the double completion protected by the request gstate?



More information about the Linux-nvme mailing list