[PATCH] nvme: set physical block size to value discovered in Identify Namespace

Martin K. Petersen martin.petersen at oracle.com
Wed Sep 20 13:01:58 PDT 2017


Keith,

> I don't think it's about "reasonable" performance; it's about getting
> extra relative performance. What else can the best performing LBAF
> indicate other than the device's preferred access alignment/granularity?
> The spec provides this hint, so it's not really a guess, but maybe
> there's a better way to make use of it instead of  considering it to be
> the physical block size? io_opt?

It should really report io_min and not physical_block_size. pbs is a
special case for spinning media.

I agree it's a bit weird to walk the format list as a heuristic. Would
be nicer to have a smallest preferred I/O size in the protocol.

> The first and last are the exact same NVMe format, but they're
> reported differently.

Yeah, we should set pbs/io_min as well.

-- 
Martin K. Petersen	Oracle Linux Engineering



More information about the Linux-nvme mailing list