[PATCH v3 3/3] nvme_fc: Avoid duplicate associations between same port pairs

Sagi Grimberg sagi at grimberg.me
Wed Sep 20 04:09:26 PDT 2017


> So we're on the same page - I'll add the option for "check for 
> duplicates" to the cli,

Agree its useful to have

> which will pass it on to the kernel, but the 
> implementation of the check will be in the kernel in each transport.
> 
> By keeping the check in the kernel it will:
> - avoid race conditions of what the "active controller" list is between 
> user and kernel space
> - keep transport-port specific knowledge of what connect fields are 
> meaningful in the transport,
> - avoids adding any infrastructure to get the connect fields into user 
> space if the cli were to do the checking.

Also agree here.



More information about the Linux-nvme mailing list