[PATCH] nvme: allow timed-out ios to retry

Keith Busch keith.busch at intel.com
Mon Sep 18 10:49:03 PDT 2017


On Mon, Sep 18, 2017 at 10:42:00AM -0700, James Smart wrote:
> On 9/18/2017 10:24 AM, Keith Busch wrote:
> > On Mon, Sep 18, 2017 at 10:15:45AM -0700, James Smart wrote:
> > > So where are we with this - what should be put in place ?
> > > 
> > > The one revision I'd make from above based is - we'd only apply this timer
> > > on an I/O marked with a fastfail flag.
> > That's unnecessary as we already return 'false' immediately from the
> > blk_noretry_request check (which checks failfast) prior to checking the
> > timeout and retry count. So, I think you're patch is good as-is.
> ok - how about a Reviewed-by ?

I accidently sent directly to Christoph off-list.

Reviewed-by: Keith Busch <keith.busch at intel.com>



More information about the Linux-nvme mailing list