[PATCHv2] nvme/pci: Print invalid SGL only once

Christoph Hellwig hch at lst.de
Fri Sep 15 10:45:09 PDT 2017


On Fri, Sep 15, 2017 at 01:05:38PM -0400, Keith Busch wrote:
> The WARN_ONCE macro returns true if the condition is true, not if the
> warn was raised, so we're printing the scatter list every time it's
> invalid. This is excessive and makes debugging harder, so this patch
> prints it just once.
> 
> Signed-off-by: Keith Busch <keith.busch at intel.com>

Looks fine,

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the Linux-nvme mailing list