[PATCH] nvme-rdma: fix possible hang when issuing commands during ctrl removal

Christoph Hellwig hch at lst.de
Mon Oct 23 01:23:45 PDT 2017


On Sun, Oct 22, 2017 at 09:42:51PM +0300, Sagi Grimberg wrote:
>  			/*
> +			 * deleting state means that the ctrl will never accept
> +			 * commands again, fail it permanently.
> +			 */
> +			if (queue->ctrl->ctrl.state == NVME_CTRL_DELETING) {
> +				nvme_req(rq)->status = NVME_SC_ABORT_REQ;
> +				return BLK_STS_IOERR;

What does the NVME_SC_ABORT_REQ buy us here compared to just returning
BLK_STS_IOERR as in the reconnecting case?  Why can't we just merge the
two cases?



More information about the Linux-nvme mailing list