[PATCH 1/5] nvme-core: Make nvme_init/uninit_ctrl setup/teardown symmetric

Sagi Grimberg sagi at grimberg.me
Thu Oct 19 08:31:38 PDT 2017


>> From: Roy Shterman <roys at lightbitslabs.com>
>>
>> Its strange to have some of the cleanup for nvme_init_ctrl in
>> nvme_free_ctrl. This cause us to have some magic ctrl refcount
>> handling in controller initialization error paths.
>>
>> Make the init/uninit symmetric so we can have a sane and
>> maintainable error sequences.
> 
> This totally conflicts with my refcount / device rework in the
> mpath patchset..

I know...

Do you want me to rebase on top of your next round of patches?



More information about the Linux-nvme mailing list