[PATCH 2/2] NVMe-CLI : WDC-Plugin Documentation for Updated Smart Log Command

Keith Busch keith.busch at intel.com
Wed Nov 29 08:38:37 PST 2017


On Tue, Nov 28, 2017 at 04:24:05PM +0000, Jeffrey Lien wrote:
> Yea, I wasn't sure why the auto-generated files are included with the txt file vs just the txt file.  It seems to make more sense to push just the txt fail and then regenerate the other files, but that doesn't match what was done in the past.  

Push now, thanks.

I'd just recommend unstaging the .html and .1 files before committing,
and I'll generate the docs as needed. It's usually not a problem when
they're included in a pull request, but when conflicts in the generated
files happen, it's easier to fix by regenerating them than trying to
merge. The only reason we have them under source control is to not have
a dependency on asciidoc to install the program.



More information about the Linux-nvme mailing list