[PATCH v3 1/1] nvme-rdma: Fix memory leak during queue allocation

Christoph Hellwig hch at lst.de
Tue Nov 28 06:26:00 PST 2017


On Tue, Nov 28, 2017 at 04:18:38PM +0200, Max Gurtovoy wrote:
>
>
> On 11/28/2017 2:42 PM, Christoph Hellwig wrote:
>> On Tue, Nov 28, 2017 at 01:36:47PM +0100, Christoph Hellwig wrote:
>>> Looks good and applied to nvme-4.15.
>>>
>>> In the long run I wonder if we want a real queue state machine intead
>>> of the flags..
>>
>> Actually, that was a little fast.  This conflicts with the MR pool
>> switch.
>
> I'll resend f needed.

Yes, please.

>>
>> Also why does it switch from rdma_destroy_qp to ib_destroy_qp?
>>
>
> because the cm_id might be destroyed (see the error flow).

Needs detailed comments please.



More information about the Linux-nvme mailing list