> +static int nvme_get_log(struct nvme_ctrl *ctrl, u8 log_page, void *log, > + size_t size) The argument alignmnet here looks a little odd, but we can fix that up on the go. Except for that this looks fine to me: Reviewed-by: Christoph Hellwig <hch at lst.de>