[PATCH 2/2] nvme: Check admin passthru command effects

Minwoo Im minwoo.im.dev at gmail.com
Thu Nov 2 02:00:15 PDT 2017


Hi Keith,

I have found a tiny typo in a comment during a review your code.

> +
> +static void nvme_passthru_end(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> +                                                               u32 effects)
> +{
> +       /*
> +        * Revaildate LBA changes prior to unfreezing. This is necessary to
> +        * prevent memory corruption if a logical block size was changed by
> +        * this command.

"Revalidate" seems okay for this comment.

> +        */
> +       if (effects & NVME_CMD_EFFECTS_LBCC)
> +               nvme_update_formats(ctrl);
> +       if (effects & (NVME_CMD_EFFECTS_LBCC | NVME_CMD_EFFECTS_CSE_MASK))
> +               nvme_unfreeze(ctrl);
> +       if (effects & NVME_CMD_EFFECTS_CCC)
> +               nvme_init_identify(ctrl);
> +       if (effects & (NVME_CMD_EFFECTS_NIC | NVME_CMD_EFFECTS_NCC))
> +               nvme_queue_scan(ctrl);
> +}
> +

I always appreciate your dedication to this amazing nvme driver.
Thanks,

Minwoo



More information about the Linux-nvme mailing list