[PATCH v2 1/2] nvme: Adding support for FW Slot info log

Sagi Grimberg sagi at grimberg.me
Tue May 30 04:30:48 PDT 2017


> This functioin has basically no common code.  I think the current
> nvme_get_log_page should be renamed to nvme_get_smart_log and moved
> to scsi.c, and you'll just add a new helper for your log page or
> even just open code it in the caller.  A little inline helper for
> setting up dword10 would be nice, though.

Agree, that'd be cleaner.



More information about the Linux-nvme mailing list