[PATCH 13/15] lpfc: Fix NVMEI's handling of NVMET's PRLI response attributes

Hannes Reinecke hare at suse.de
Thu May 11 00:50:32 PDT 2017


On 05/10/2017 09:07 PM, James Smart wrote:
> Code review of NVMEI's FC_PORT_ROLE_NVME_DISCOVERY
> looked wrong.
> 
> Discussions with storage architecture team clarified
> NVMEI's audit of the PRLI response port roles.  Following up
> discussion with code review showed a few minor corrections
> were required - especially in anticipation of NVME auto
> discovery.
> 
> During PRLI, NVMEI should sent prli_init - which it it
> does.  NVMET should send prli_tgt and prli_disc - which it does.
> When NVMEI receives a PRLI Response now, it audits the
> incoming target bits and stores the attributes in the
> corresponding NDLP.  Later, when NVMEI registers the NVME
> rport, it uses the stored ndlp attributes to set the rport
> port_roles correctly.
> 
> Signed-off-by: Dick Kennedy <dick.kennedy at broadcom.com>
> Signed-off-by: James Smart <james.smart at broadcom.com>
> ---
>  drivers/scsi/lpfc/lpfc_disc.h      | 1 +
>  drivers/scsi/lpfc/lpfc_nportdisc.c | 6 ++++++
>  2 files changed, 7 insertions(+)
> 
Reviewed-by: Hannes Reinecke <hare at suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)



More information about the Linux-nvme mailing list